-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable28] Bug/48678/restore dav error response #49482
base: stable28
Are you sure you want to change the base?
Conversation
c7ada10
to
fde56d6
Compare
Conflicts: Constructor property promotion and Imports in Server and ServerFactory, New integration test in caldav.feature |
$error->setAttribute('xmlns:s', self::NS_SABREDAV); | ||
$DOM->appendChild($error); | ||
|
||
$h = function ($v) { |
Check notice
Code scanning / Psalm
MissingClosureReturnType Note
$error->setAttribute('xmlns:s', self::NS_SABREDAV); | ||
$DOM->appendChild($error); | ||
|
||
$h = function ($v) { |
Check notice
Code scanning / Psalm
MissingClosureParamType Note
} | ||
class BrowserErrorPagePlugin extends ServerPlugin { | ||
/** @var Server */ | ||
private $server; |
Check notice
Code scanning / Psalm
MissingConstructor Note
$this->server->httpResponse->setHeader('Content-Type', 'application/xml; charset=utf-8'); | ||
} | ||
public function generateBody(int $httpCode) { | ||
$request = \OC::$server->getRequest(); |
Check notice
Code scanning / Psalm
DeprecatedMethod Note
fde56d6
to
424a53a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking
…eption output" This reverts commit e202896. Signed-off-by: Daniel Kesselberg <[email protected]>
This reverts commit d2bf361. Signed-off-by: Daniel Kesselberg <[email protected]>
This reverts commit 9992e7d. Signed-off-by: Daniel Kesselberg <[email protected]>
424a53a
to
7cbc5ba
Compare
Signed-off-by: Daniel Kesselberg <[email protected]>
7cbc5ba
to
ff57dc8
Compare
@kesselb keep or close? |
Backport of #49004
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.